Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Refactor events for remediation controllers #1008

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

aniruddha2000
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squash commits
  • include documentation
  • add unit tests

@aniruddha2000
Copy link
Contributor Author

@janiskemper @guettli please have a look. I tried to add events for most of the places, but however, I don't understand this

when the machine is healthy again and the remediation object gets removed.

@janiskemper
Copy link
Contributor

to me it looks mostly good. The case that you have mentioned there is something that we cannot do without adding a finalizer to the remediation object, which I find a bit extreme to get an event..
Right now, the remediation object gets deleted and since we don't have a finalizer, we don't even realize.

@guettli would you say that this is so important that we should introduce a finalizer?

@guettli
Copy link
Contributor

guettli commented Oct 18, 2023

@janiskemper at the moment I think it is not needed to add finalizer to get an event. Maybe we will add this later.

@aniruddha2000 aniruddha2000 marked this pull request as ready for review October 19, 2023 05:41
@syself-bot syself-bot bot added the area/code Changes made in the code directory label Oct 19, 2023
@aniruddha2000 aniruddha2000 merged commit 830c44c into main Oct 19, 2023
13 checks passed
@aniruddha2000 aniruddha2000 deleted the ani/issues/open-source/55 branch October 19, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/code Changes made in the code directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants