🐛 Fix provision condition time lag #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guettli
previously approved these changes
Oct 12, 2023
There has been a time lag in the condition that shows the provisioning status of the HetznerBareMetalHost. It was only updated after a new reconcilement has started, not during the reconcilement where the state actually changed. This commit places the update of the condition to the start of the respective functions to ensure it is up to date.
janiskemper
force-pushed
the
fix-provision-condition
branch
from
9e3d7ae
to
7074876
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
There has been a time lag in the condition that shows the provisioning status of the HetznerBareMetalHost. It was only updated after a new reconcilement has started, not during the reconcilement where the state actually changed.
This commit places the update of the condition to the start of the respective functions to ensure it is up to date.
TODOs: