🌱 improve event of GetHardwareDetailsDebug

don't show "stderr" if there is no output.
syself · Mar 18, 2024 · ae5e47b · ae5e47b
1 parent 43b8a53
commit ae5e47b
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/pkg/services/baremetal/host/host.go b/pkg/services/baremetal/host/host.go
@@ -541,7 +541,11 @@ func (s *Service) actionRegistering() actionResult {
 	if output.Err != nil {
 		return actionError{err: fmt.Errorf("failed to obtain hardware for debugging: %w", output.Err)}
 	}
-	record.Eventf(s.scope.HetznerBareMetalHost, "GetHardwareDetails", "%s\n\nstderr:\n%s", output.StdOut, out.StdErr)
+	msg := fmt.Sprintf("%s\n\n", output.StdOut)
+	if out.StdErr != "" {
+		msg += fmt.Sprintf("stderr:\n%s\n\n", out.StdErr)
+	}
+	record.Eventf(s.scope.HetznerBareMetalHost, "GetHardwareDetails", msg)
 
 	if s.scope.HetznerBareMetalHost.Spec.Status.HardwareDetails == nil {
 		hardwareDetails, err := getHardwareDetails(sshClient)