feat(cloudauth): Support accounts with regulatory framework field #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change summary: ----------------- - Add support for onboarding cloudauth accounts with regulatory framework type - Updated cloudauth proto pb.go
ravinadhruve10
commented
Oct 17, 2024
| @@ -59,6 +59,7 @@ resource "sysdig_secure_cloud_auth_account" "azure_sample" { | |||
| enabled = true | |||
| provider_tenant_id = "%s" | |||
| provider_alias = "some-alias" | |||
| regulatory_framework = "REGULATORY_FRAMEWORK_UNSPECIFIED" | |||
There was a problem hiding this comment.
I don't believe this is necessary. Not specifying the regulatory_framework here will make protobuf automatically set it to REGULATORY_FRAMEWORK_UNSPECIFIED. Basically the meaning of this enum value itself is that the field was not provided/populated in the request.
The ACC tests are failing because of BE changes not available in prod envs. Once they start passing, without this change also they should pass IMO.
There was a problem hiding this comment.
Yeah, we discussed this so I'll get rid off these
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change summary: