-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(azure): customize entra and platform logs (SSPROD-43735) #52
Conversation
b85e015
to
15c7ea8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to make this backwards compatible, so the default setup should enable everything. We should also continue supporting enable_entra variable for the time being, for whomever has a onboarding setup generated after that was introduced
Co-authored-by: Paolo Polidori <[email protected]>
Co-authored-by: Paolo Polidori <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please adapt the README to add the new variables
Also mark enabled_entra_logs
as deprecated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm this is working, tested pointing to the local module on skosier/modular-onboarding/entra-logs
branch with this:
enabled_entra_logs = ["SignInLogs","NonInteractiveUserSignInLogs","ServicePrincipalSignInLogs","ManagedIdentitySignInLogs","ProvisioningLogs","ADFSSignInLogs","RiskyUsers","UserRiskEvents","NetworkAccessTrafficLogs","RiskyServicePrincipals","ServicePrincipalRiskEvents","EnrichedOffice365AuditLogs","MicrosoftGraphActivityLogs"]
enabled_platform_logs = ["Administrative","Policy"]
…oarding/entra-logs' into skosier/modular-onboarding/entra-logs
Co-authored-by: Paolo Polidori <[email protected]>
8d7e556
to
2730c1c
Compare
No description provided.