Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove subid from eh namespace #22

Merged
merged 3 commits into from
Jan 3, 2024
Merged

fix: remove subid from eh namespace #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e79ec8d
remove subid from eh namespace
matteopasa Dec 19, 2023
762c899
remove default values for values that we get as input
matteopasa Dec 19, 2023
f6577a1
add back default for resource group and diagnostic settings
matteopasa Dec 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/services/event-hub-data-source/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ resource "azurerm_resource_group" "sysdig_resource_group" {
# Create an Event Hub Namespace for Sysdig
#---------------------------------------------------------------------------------------------
resource "azurerm_eventhub_namespace" "sysdig_event_hub_namespace" {
name = "${var.event_hub_namespace_name}-${var.subscription_id}"
name = var.event_hub_namespace_name
matteopasa marked this conversation as resolved.
Show resolved Hide resolved
location = azurerm_resource_group.sysdig_resource_group.location
resource_group_name = azurerm_resource_group.sysdig_resource_group.name
sku = var.namespace_sku
Expand Down
1 change: 0 additions & 1 deletion modules/services/event-hub-data-source/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ variable "namespace_sku" {
variable "event_hub_namespace_name" {
type = string
description = "Name of the Event Hub Namespace to be created"
default = "sysdig"
}

variable "event_hub_name" {
Expand Down