Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(agentless-scanning): regional roles #26

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Conversation

cgeers
Copy link
Contributor

@cgeers cgeers commented Nov 8, 2024

No description provided.

@cgeers cgeers requested a review from a team as a code owner November 8, 2024 18:47
@cgeers cgeers force-pushed the feat/scanning/regional_roles branch from 886a21b to 9b524f8 Compare November 8, 2024 18:50
@cgeers cgeers force-pushed the feat/scanning/regional_roles branch 2 times, most recently from df06699 to 0aa64fa Compare November 8, 2024 22:02
modules/agentless-scanning/main.tf Show resolved Hide resolved
modules/agentless-scanning/main.tf Show resolved Hide resolved
modules/agentless-scanning/main.tf Outdated Show resolved Hide resolved
modules/agentless-scanning/main.tf Outdated Show resolved Hide resolved
@cgeers cgeers force-pushed the feat/scanning/regional_roles branch from 59bcab3 to ef7226a Compare November 12, 2024 16:24
Copy link
Contributor

@ravinadhruve10 ravinadhruve10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Chris for the changes! LGTM, just 2 points :-

  • It will be great if we can test this before merging!
  • can we also please update the README as needed, since this is user-facing?

modules/agentless-scanning/organizational.tf Show resolved Hide resolved
@cgeers cgeers enabled auto-merge (squash) November 12, 2024 21:02
@cgeers cgeers disabled auto-merge November 12, 2024 21:30
@cgeers cgeers force-pushed the feat/scanning/regional_roles branch from f5367a7 to 349024c Compare November 12, 2024 21:32
@cgeers cgeers enabled auto-merge (squash) November 12, 2024 21:33
@cgeers cgeers merged commit 6869379 into main Nov 12, 2024
@cgeers cgeers deleted the feat/scanning/regional_roles branch November 12, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants