Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALB Golden Signals.json existing problem #253

Closed
lvwenl opened this issue Apr 11, 2023 · 1 comment · Fixed by #254
Closed

ALB Golden Signals.json existing problem #253

lvwenl opened this issue Apr 11, 2023 · 1 comment · Fixed by #254

Comments

@lvwenl
Copy link

lvwenl commented Apr 11, 2023

Hello , file content There is a missing "}" at line 692
image

@Dlorite
Copy link
Collaborator

Dlorite commented Apr 11, 2023

Good catch, thanks for reporting

Dlorite added a commit that referenced this issue Apr 17, 2023
@Dlorite Dlorite linked a pull request Apr 17, 2023 that will close this issue
Dlorite added a commit that referenced this issue Apr 17, 2023
Dlorite added a commit that referenced this issue Apr 17, 2023
* Add automatically resources (#250)

* Add automatically resources

* Add feedback and improvements

* Add missing alerts

* Update apps files

* Add new changes and improvements

* Update buildandDeploy.yml

* Update buildandDeploy.yml

* Add automatically resources (#251)

* Add automatically resources

* Add feedback and improvements

* Add missing alerts

* Update apps files

* Add new changes and improvements

* Fix some issues

* Remove wrong files

* Add dashboard yaml for opa

* Add README for harbor

* Remove readme to add later

* Add README.md

* Add missing README.md files and comment test for now

* Change the github action

* Change the github action

* Add deploy in staging

* Add new images

* ADD fluentd and ntp dashboards images (#252)

* Improve Readme files

* Add links of the exporters as uri

* Move coming soon to future apps

* Add prerequisites for some ootb integrations

* Update actions

* [Issue #253] Fix missing } (#254)

* Fix Python version in the action

---------

Co-authored-by: Jaime Yera Hidalgo <[email protected]>
Co-authored-by: David Lorite Solanas <[email protected]>
@Dlorite Dlorite closed this as completed Apr 17, 2023
Dlorite added a commit that referenced this issue May 4, 2023
* Add automatically resources (#250)

* Add automatically resources

* Add feedback and improvements

* Add missing alerts

* Update apps files

* Add new changes and improvements

* Update buildandDeploy.yml

* Update buildandDeploy.yml

* Add automatically resources (#251)

* Add automatically resources

* Add feedback and improvements

* Add missing alerts

* Update apps files

* Add new changes and improvements

* Fix some issues

* Remove wrong files

* Add dashboard yaml for opa

* Add README for harbor

* Remove readme to add later

* Add README.md

* Add missing README.md files and comment test for now

* Change the github action

* Change the github action

* Add deploy in staging

* Add new images

* ADD fluentd and ntp dashboards images (#252)

* Improve Readme files

* Add links of the exporters as uri

* Move coming soon to future apps

* Add prerequisites for some ootb integrations

* Update actions

* [Issue #253] Fix missing } (#254)

* Fix Python version in the action

* Improve and fix files

* Fix actions

---------

Co-authored-by: Jaime Yera Hidalgo <[email protected]>
Co-authored-by: David Lorite Solanas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants