Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(agent): [SMAGENT-8138] add full securityContext to agent charts #2017

Merged
merged 3 commits into from
Dec 17, 2024

Conversation

iurly
Copy link
Collaborator

@iurly iurly commented Nov 5, 2024

Update the agent charts so to include a full securityContext. Beware of kubernetes/kubernetes#125012 affecting Windows kubelet.

What this PR does / why we need it:

Checklist

  • Title of the PR starts with type and scope, (e.g. feat(agent,node-analyzer,sysdig-deploy):)
  • Chart Version bumped for the respective charts
  • Variables are documented in the README.md (or README.tpl in some charts)
  • Check GithubAction checks (like lint) to avoid merge-check stoppers
  • All test files are added in the tests folder of their respective chart and have a "_test" suffix

@iurly iurly force-pushed the SMAGENT-8138-securitycontext branch from d5c3e06 to 307990c Compare December 6, 2024 15:53
Update the agent charts so to include a full securityContext.
Beware of kubernetes/kubernetes#125012
affecting Windows kubelet.

Also add relevant unit tests.
@iurly iurly force-pushed the SMAGENT-8138-securitycontext branch from 307990c to 1ec31d7 Compare December 12, 2024 15:18
@iurly iurly marked this pull request as ready for review December 12, 2024 15:19
@iurly iurly requested a review from a team as a code owner December 12, 2024 15:19
@iurly iurly merged commit 550c06f into main Dec 17, 2024
4 checks passed
@iurly iurly deleted the SMAGENT-8138-securitycontext branch December 17, 2024 10:09
iurly added a commit that referenced this pull request Jan 8, 2025
… agent charts (#2102)

Update the agent charts so to include a full securityContext.
Beware of kubernetes/kubernetes#125012 affecting Windows kubelet.

Compared to #2017, just removed the "add: -ALL" part which was breaking some systems like ROKS and probably also Azure, which seemed unnecessary (probably redundant given we have privileged: true).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants