Merge pull request blockscout#5285 from blockscout/vb-fix-contract-by…

…tecode-twins-feature

Fix verified smart-contract bytecode twins feature

CHANGELOG.md

@@ -4,6 +4,7 @@
 - [#5268](https://github.com/blockscout/blockscout/pull/5268) - Contract names display improvement
 
 ### Fixes
+- [#5285](https://github.com/blockscout/blockscout/pull/5285) - Fix verified smart-contract bytecode twins feature
 - [#5269](https://github.com/blockscout/blockscout/pull/5269) - Address Page: Fix implementation address align
 - [#5264](https://github.com/blockscout/blockscout/pull/5264) - Fix bug with 500 response on `partial` sourcify status
 - [#5263](https://github.com/blockscout/blockscout/pull/5263) - Fix bug with name absence for contract

apps/explorer/lib/explorer/chain.ex

@@ -4187,10 +4187,7 @@ defmodule Explorer.Chain do
          %{contract_code: %Chain.Data{bytes: contract_code_bytes}} <- target_address do
       target_address_hash = target_address.hash
 
-      contract_code_md5 =
-        Base.encode16(:crypto.hash(:md5, "\\x" <> Base.encode16(contract_code_bytes, case: :lower)),
-          case: :lower
-        )
+      contract_code_md5 = Helper.contract_code_md5(contract_code_bytes)
 
       verified_contract_twin_query =
         from(

apps/explorer/lib/explorer/smart_contract/helper.ex

@@ -42,10 +42,7 @@ defmodule Explorer.SmartContract.Helper do
   def add_contract_code_md5(%{address_hash: address_hash_string} = attrs) when is_binary(address_hash_string) do
     with {:ok, address_hash} <- Chain.string_to_address_hash(address_hash_string),
          {:ok, address} <- Chain.hash_to_address(address_hash) do
-      contract_code_md5 =
-        :md5
-        |> :crypto.hash(address.contract_code.bytes)
-        |> Base.encode16(case: :lower)
+      contract_code_md5 = contract_code_md5(address.contract_code.bytes)
 
       attrs
       |> Map.put_new(:contract_code_md5, contract_code_md5)
@@ -57,10 +54,7 @@ defmodule Explorer.SmartContract.Helper do
   def add_contract_code_md5(%{address_hash: address_hash} = attrs) do
     case Chain.hash_to_address(address_hash) do
       {:ok, address} ->
-        contract_code_md5 =
-          :md5
-          |> :crypto.hash(address.contract_code.bytes)
-          |> Base.encode16(case: :lower)
+        contract_code_md5 = contract_code_md5(address.contract_code.bytes)
 
         attrs
         |> Map.put_new(:contract_code_md5, contract_code_md5)
@@ -71,4 +65,10 @@ defmodule Explorer.SmartContract.Helper do
   end
 
   def add_contract_code_md5(attrs), do: attrs
+
+  def contract_code_md5(bytes) do
+    :md5
+    |> :crypto.hash(bytes)
+    |> Base.encode16(case: :lower)
+  end
 end

apps/explorer/test/support/factory.ex

@@ -34,6 +34,8 @@ defmodule Explorer.Factory do
     StakingPoolsDelegator
   }
 
+  alias Explorer.SmartContract.Helper
+
   alias Explorer.Market.MarketHistory
   alias Explorer.Repo
 
@@ -607,10 +609,7 @@ defmodule Explorer.Factory do
   def smart_contract_factory do
     contract_code_info = contract_code_info()
 
-    bytecode_md5 =
-      :md5
-      |> :crypto.hash(contract_code_info.bytecode)
-      |> Base.encode16(case: :lower)
+    bytecode_md5 = Helper.contract_code_md5(contract_code_info.bytecode)
 
     %SmartContract{
       address_hash: insert(:address, contract_code: contract_code_info.bytecode, verified: true).hash,