Updating tinygltfloader

[AurL]

Hi,

Just a few words here to let you know that we are working on this project and have add a few updates (skin support, animation, PBR materials, and writing function (maybe out of the scope)).

We are currently working on updating it to handle glTF 2.0 files including the breaking changes that are being pushed:

• schema update (arrays instead of dicts)
• PBR material definition + extension
• skinning updates
  etc.

We will probably push a PR here if you are interested

[syoyo]

Super cool!

Yeah, supporting glTF 2.0, PBR material and skin are TODO list, but I couldn't spare enough time for it these days.
I appreciate your PR!

[AurL]

Hi,

It's almost done.
I am having some issues with a few details in the code.
These static members sample 1 and sample 2 are making our code leave with a Inconsistency detected by ld.so: dl-close.c: 762: _dl_close: Assertion 'map->l_init_called' failed!'. I'm not sure how to fix this better than removing the static keyword.
Do you have any hint ?

I'll open the PR soon, then don't hesitate to take a good look as it includes a lot of changes.
It could be cool to discuss it a bit, if you have any questions.

Side note: for our use, we also added serialization functions in tinygltfloader. It still needs to be updated with the latest glTF 2.0 updates, but I wonder if it would make sense to include it in this project ?
I could also open a PR for this once it's updated.

[syoyo]

Thanks!

These static members sample 1 and sample 2 are making our code leave with a Inconsistency detected by ld.so: dl-close.c: 762: _dl_close: Assertion 'map->l_init_called' failed!'

This initialization idiom is for suppressing a clang warning: https://stackoverflow.com/questions/15708411/how-to-deal-with-global-constructor-warning-in-clang

But if you encounter a runtime error with this technique, we can suppress clang warning by adding clang pragma explicitly.

I wonder if it would make sense to include it in this project ?

Serialization feature is cool and would be better to include into this project(I have writer example https://github.com/syoyo/tinygltfloader/tree/master/examples/writer as you may know).
We may be better to rename TinyGLTFLoader to TinyGLTFLib or similar.

[syoyo]

I have created tinygltf repo

https://github.com/syoyo/tinygltf

So new version will be moved to this repo. tinygltfloader repo will remain for a while for existing glTF 1.0 programs.

[syoyo]

Please send PR to https://github.com/syoyo/tinygltf , @AurL

[AurL]

Ok cool, thanks a lot for your answers!

[syoyo]

FYI, I have reverted to use static Value null_value in this recent commit: bc83dbb

We cannot remove static keyword since Get function returns the reference of a variable.

[AurL]

@syoyo thanks! Could you report it on tinygltf ? or should I cherry-pick it and include it in my PR on tinygltf ?
I tested and the issue is still not fixed (since the variable is still declared as static ?)

[AurL]

The PR is opened here, you can take a look when you have time.
Please don't merge it too quickly, I guess it will need some discussions

[syoyo]

Awesome! I'll review it!

I tested and the issue is still not fixed (since the variable is still declared as static ?)

Hmm... which compiler/os/glibc do you use?

[syoyo]

I tested and the issue is still not fixed (since the variable is still declared as static ?)

I have changed to use private static variable approach.

d1fcf24

@AurL could you please try this?

[AurL]

I tested with this commit and in a first time, I had a link issue. The static field needed to be declared after the classe.
I added a definition but then it throws the same Inconsistency detected by ld.so: dl-close.c: 762: _dl_close: Assertion map->l_init_called' failed!`.

I'm surprised to be the only one having this issue.
OS: Ubuntu 14.04
compiler: g++ (Ubuntu 4.8.4-2ubuntu1~14.04.3) 4.8.4
glibc: EGLIBC 2.19-0ubuntu6.5

[syoyo]

Inconsitency detected error may be due to mixing precompiled another .so's or looking different libc/ld.so on your system:

Linuxbrew/brew#73

If you still encounter the problem, please post reproducable source code and make script
(It looks you are building .so library. .so build is not tested well on my side)