Machine state doesn't return to MACHINE_READY

[mhlong10]

After issuing certain commands the machine state doesn't return back to a MACHINE_READY state and remains in a MACHINE_CYCLE state. I first noticed this on the following:

SEND: G10 L20 P1 Z10
RESP: {"r":{},"f":[1,0,15]}
SEND: ?
RESP: {"r":{"sr":{"posx":0,"posy":0,"posz":10,"posa":0,"mpox":0,"mpoy":0,"mpoz":0,"mpoa":0,"stat":5,"vel":0}},"f":[1,0,2]}

This also happens for G28.1 or even G0 with no parameters. Looking at the code, there are many code paths which don't end the cycle and the machine state stays in the MACHINE_CYCLE state. If nothing is queued to the planner then it looks like cm_cycle_end or its friends are not called.

Note - sending any command which does normally end the cycle will bring the state back to MACHINE_READY.

Why does this matter - The issue I have is that I have a gcode sender which for some manual operations will wait for the machine to reach an idle state. So if for example I zero an axis with the G10 command and then try to run a sequence of G code commands, the client will not start the sequence because the machine never returns to ready/idle. I could send something like G4 after the G10 to clear the condition but that seems like a hack.

I see that there is another issue logged #223 but no reply or fix for that. Is this intentionally not being fixed?

[mhlong10]

I see that #367 is the same issue and there is a fix #409 which has not been merged. I'm closing this and will comment on that.