Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type imports for Node16 module resolution #3

Merged
merged 1 commit into from
Sep 30, 2022
Merged

Fix type imports for Node16 module resolution #3

merged 1 commit into from
Sep 30, 2022

Conversation

remcohaszing
Copy link
Member

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

The TypeScript node16 module resolution is more strict and requires the .js file extension, even for type imports.

@remcohaszing remcohaszing requested a review from a team September 30, 2022 08:51
@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Sep 30, 2022
@remcohaszing remcohaszing added 🐛 type/bug This is a problem ☂️ area/types This affects typings labels Sep 30, 2022
@wooorm wooorm merged commit bbb5ebe into main Sep 30, 2022
@wooorm wooorm deleted the fix-node16-types-resolution branch September 30, 2022 16:41
@wooorm wooorm added the 💪 phase/solved Post is done label Sep 30, 2022
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Sep 30, 2022
@wooorm
Copy link
Member

wooorm commented Sep 30, 2022

Thanks, released in 1.3.1!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wooorm wooorm wooorm approved these changes

@ChristianMurphy ChristianMurphy ChristianMurphy approved these changes

@JounQin JounQin JounQin approved these changes

Assignees
No one assigned
Labels
☂️ area/types This affects typings 💪 phase/solved Post is done 🐛 type/bug This is a problem
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@remcohaszing @wooorm @ChristianMurphy @JounQin