-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Enable regular reconciliation of promise workflows #219
Comments
|
This can be achieved by customizing manager cache options. See: https://github.com/kubernetes-sigs/controller-runtime/blob/main/pkg/cache/cache.go#L170 |
abangser
changed the title
[feat] Enable regular reconciliation loops to identify/fix drift
[feat] Enable regular reconciliation of promise workflows
Oct 14, 2024
Documentation
|
abangser
added a commit
that referenced
this issue
Oct 15, 2024
This is the first of a handful of features which will combine to provide regular reconciliation across the full Kratix platform. Right now the reconcilation time is set to 10 hours but will be configurable in the future. There are two notes here to be aware of: 1. If the kratix controller restarts, there may be *more* reconciliation loops scheduled. That is why this is saying "at least" every 10 hours rather than "at most" or "exactly". 2. The workflows will run, but if the declarative outputs are not changed, the write to the statestore will not be triggered. Making sure to reconcile the actual contents of the statestore with the declarede contents is an upcoming piece of work to in this stream. closes #219 Co-authored-by: Sapphire Mason-Brown <[email protected]> Co-authored-by: Derik Evangelista <[email protected]> Co-authored-by: Rich Barton-Cooper <[email protected]>
abangser
added a commit
that referenced
this issue
Oct 15, 2024
This is the first of a handful of features which will combine to provide regular reconciliation across the full Kratix platform. Right now the reconcilation time is set to 10 hours but will be configurable in the future. There are two notes here to be aware of: 1. If the kratix controller restarts, there may be *more* reconciliation loops scheduled. That is why this is saying "at least" every 10 hours rather than "at most" or "exactly". 2. The workflows will run, but if the declarative outputs are not changed, the write to the statestore will not be triggered. Making sure to reconcile the actual contents of the statestore with the declarede contents is an upcoming piece of work to in this stream. closes #219 Co-authored-by: Sapphire Mason-Brown <[email protected]> Co-authored-by: Derik Evangelista <[email protected]> Co-authored-by: Rich Barton-Cooper <[email protected]>
This was referenced Oct 14, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With Kratix being a Kubernetes controller, it is expected that it could reconcile at any point. The most common triggers are:
It is also common to have a regular interval for that reconciliation to enable drift detection and re-alignment in between the active triggers mentioned above.
Kratix should have a sensible default for regular reconciliations and also allow user override of this number within a reasonable range.
Assumptions
Scenarios
Note: While valuable there are a few outstanding aspects that will make this more complete. Referencing these in the docs will be helpful. These will all be covered in additional pieces of work:
Engineering notes
TODO List
The text was updated successfully, but these errors were encountered: