Introduce NumberField component to Symbiosis #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test case for handling dates with timezone information has been updated to explicitly state that the current implementation does not handle timezone information correctly. This change provides clearer expectations for the behavior of the calculateCountForDataOnDates function and serves as a reminder that timezone handling is a known limitation or area for potential improvement in the future.
Adds a new SVG icon 'symbiosis-plus' to the UI package and updates the icon type definitions to include this new icon. This enhancement expands the available icon set, providing more options for visual elements in the user interface.
Introduces a new NumberField component to the UI package, providing a customizable input for numeric values. This component includes features such as increment/decrement buttons, min/max value constraints, and error handling. It enhances the form input options available in the UI library, allowing for more precise numeric data entry and validation.
Adds a new utility class 'hide-internal-input-elements' to remove the default spinner buttons from number input fields across different browsers. This improves the consistency of input field appearance and allows for more control over the UI design.
Introduces a new set of stories for the NumberField component in Storybook. This addition enhances the documentation and testing capabilities for the NumberField, showcasing various configurations and use cases. The stories include examples of default usage, min/max constraints, error states, custom step values, disabled state, different sizes, controlled component behavior, and custom styling options.
…se current functionality
bratsos
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
calculateCountForDataOnDates, to not fail and to clarify that the function does NOT handle timezones as it exists to provide clear expectations for the function.NumberFieldcomponentNumberFieldThe UI:
Screen.Recording.2024-11-12.at.11.08.35.AM.mov