Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce tooltip component #1

Merged
merged 9 commits into from
Sep 4, 2024
Merged

Conversation

DGiannaris
Copy link
Member

@DGiannaris DGiannaris commented Aug 26, 2024

This PR:

  • Introduces radix-ui/react-tooltip dependency
  • Introduces new Tooltip component
  • Adds storybook stories for Tooltip component
  • Make sure Postcss exports default for storybook

UI:

Screen.Recording.2024-08-26.at.4.06.59.PM.mov

Note:

Tried to allow overiding tooltip content but postcss export was off, removing css rules from the loaded styles. You could see the tw classNames existed in an element but the corresponding styles were not there.
After changing that I made some minor changes for the overiding logic and added a story that showcases it.

@DGiannaris DGiannaris added the enhancement New feature or request label Aug 26, 2024
@DGiannaris DGiannaris self-assigned this Aug 26, 2024
@DGiannaris DGiannaris requested a review from bratsos August 26, 2024 14:54
@DGiannaris DGiannaris force-pushed the feature/introduce-tooltip-component branch 2 times, most recently from 9ff1f56 to 2d37081 Compare August 28, 2024 13:45
@DGiannaris DGiannaris force-pushed the feature/introduce-tooltip-component branch from 2d37081 to b59f1f5 Compare September 2, 2024 16:00
@DGiannaris DGiannaris force-pushed the feature/introduce-tooltip-component branch from b59f1f5 to b903ad0 Compare September 3, 2024 07:33
@DGiannaris DGiannaris force-pushed the feature/introduce-tooltip-component branch from b903ad0 to 915095f Compare September 3, 2024 11:43
export const plugins = {
tailwindcss: {},
autoprefixer: {},
export default {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Copy link
Contributor

@bratsos bratsos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! LGTM

@DGiannaris DGiannaris merged commit 5e707da into main Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants