-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce tooltip component #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DGiannaris
force-pushed
the
feature/introduce-tooltip-component
branch
2 times, most recently
from
August 28, 2024 13:45
9ff1f56
to
2d37081
Compare
DGiannaris
force-pushed
the
feature/introduce-tooltip-component
branch
from
September 2, 2024 16:00
2d37081
to
b59f1f5
Compare
DGiannaris
force-pushed
the
feature/introduce-tooltip-component
branch
from
September 3, 2024 07:33
b59f1f5
to
b903ad0
Compare
DGiannaris
force-pushed
the
feature/introduce-tooltip-component
branch
from
September 3, 2024 11:43
b903ad0
to
915095f
Compare
bratsos
reviewed
Sep 3, 2024
export const plugins = { | ||
tailwindcss: {}, | ||
autoprefixer: {}, | ||
export default { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
bratsos
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
radix-ui/react-tooltip
dependencyTooltip
componentTooltip
componentUI:
Screen.Recording.2024-08-26.at.4.06.59.PM.mov
Note:
Tried to allow overiding tooltip content but postcss export was off, removing
css rules
from the loaded styles. You could see thetw classNames
existed in an element but the corresponding styles were not there.After changing that I made some minor changes for the overiding logic and added a story that showcases it.