Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lightning): use min0ConfTxFee only for orders with 0 client balance #1542

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

pwltr
Copy link
Collaborator

@pwltr pwltr commented Feb 8, 2024

Description

BT only accepts turbo or 0-conf payment channels for orders with 0 client balance. The min-0conf-tx-fee is also sometimes excessive. We can use a lower fee for orders with a balance.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

@pwltr pwltr requested a review from coreyphillips February 8, 2024 13:59
@pwltr pwltr merged commit 52fbd29 into master Feb 9, 2024
3 of 4 checks passed
@pwltr pwltr deleted the fix/channel-order-fee branch February 9, 2024 12:16
@JeanlChristophe JeanlChristophe added this to the v.1 milestone Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants