feat: new ldk backup server restore #1294
Conversation
Jasonvdb
force-pushed
the
new-ldk-backups
branch
from
a2914d3 to
7eda2bf
Compare
|
should performRemoteLdkBackup be removed? Also list in Settings -> Backup and Restore screen doesn't represent actual state now. We need a way to get backup info from ldk to update it |
| if (fileListRes.isErr()) { | ||
| return err(fileListRes.error); | ||
| } |
There was a problem hiding this comment.
this throws "Error: Request failed. Missing response from backup server."
I believe we should return { backupExists: false } in this case
There was a problem hiding this comment.
Might be a server issue here, if there is no backup then the list is just empty. I don't want to assume an error means there's no backup. I'll get back to you on this.
There was a problem hiding this comment.
I'm testing with server from development.template. I've created a wallet using master branch, then I'm trying to restore in using new-ldk-backups and I'm getting this error
There was a problem hiding this comment.
I've updated the env with new backup server. SSL was required as well as a backend update.
I was thinking let me remove it right after we've done a few rounds of live testing. Just in case.
True. Now we don't really have a last backup time to display. I do have a self check function for the backups maybe we can run this when this view is loaded to show the state. |
Description
Linked Issues/Tasks
Does not resolve existing restore issues it should prevent further ones from occurring.
#713
#770
Type of change
Tests
QA Notes
Backup and restoring lightning funds should be reliable now