Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Companion config do not seem to enable/disable rules as expected #39

Closed
LexiconCode opened this issue Oct 17, 2019 · 4 comments
Closed
Labels
bug Something isn't working

Comments

@LexiconCode
Copy link

VSCodeCcrRule = ["VSCodeNonCcrRule"]

This can be seen by saying enable Visual Studio Code Non Continuous

One would expect a few things to happen

  • saying enable visual studio code continuous the VSCodeCcrRule both should be enabled simultaneously
  • That if either VSCodeCcrRule or VSCodeNonCcrRule disabled they both would become disabled simultaneously

Currently it seems unable to disable VSCodeNonCcrRule once enabled say disable Visual Studio Code Non Continuous

I have to experiment with other companion rules.

@synkarius
Copy link
Owner

This is actually the "correct" behavior unless old Caster did otherwise. I'm not saying it's how it should be, just that in terms of old/new feature parity, I don't think this is a rewrite-related "bug". I would test old Caster's behavior, but I am traveling this entire weekend and my laptop is not Windows.

@LexiconCode
Copy link
Author

With my expectations sure but being unable to disable a rule once activated could be related?

@synkarius
Copy link
Owner

Sorry, I misread what you said before. What I meant to say is that the "correct" behavior is:

  • enabling a rule with a companion enables them both
  • disabling the rule which enabled the companion disables the companion
  • disabling the companion does NOT disable the rule

I thought you were asking for the third thing there. It seems now that you're saying that you just can't shut off the companion, period, after enabling via the rule.

@synkarius synkarius added the bug Something isn't working label Oct 21, 2019
@LexiconCode
Copy link
Author

Strange I'm not able to reproduce this now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants