Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No auto-config check except login/cache #995

Merged
merged 1 commit into from
Jul 14, 2024
Merged

No auto-config check except login/cache #995

merged 1 commit into from
Jul 14, 2024

Conversation

synfinatic
Copy link
Owner

No longer check if we should update the ~/.aws/config file except for the login and cache commands.

tags command no longer supports --force-update

Fixes: #974

Copy link

codecov bot commented Jul 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Project coverage is 84.19%. Comparing base (d351922) to head (79b8124).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #995      +/-   ##
==========================================
- Coverage   84.60%   84.19%   -0.41%     
==========================================
  Files          42       42              
  Lines        3059     3074      +15     
==========================================
  Hits         2588     2588              
- Misses        378      393      +15     
  Partials       93       93              
Flag Coverage Δ
unittests 84.19% <0.00%> (-0.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
internal/sso/cache.go 54.24% <0.00%> (-2.40%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d351922...79b8124. Read the comment docs.

@synfinatic synfinatic force-pushed the no-auto-config branch 2 times, most recently from 363a8a2 to b130d69 Compare July 14, 2024 04:11
No longer check if we should update the `~/.aws/config` file except for
the login and cache commands.

tags command no longer supports --force-update

Fixes: #974
@synfinatic synfinatic merged commit 3c21d64 into main Jul 14, 2024
5 of 7 checks passed
@synfinatic synfinatic deleted the no-auto-config branch July 14, 2024 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only auto update ~/.aws/config for login/cache command
1 participant