Ssl support #925
Merged
Ssl support #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #925 +/- ##
==========================================
+ Coverage 83.40% 83.64% +0.24%
==========================================
Files 40 40
Lines 2843 2934 +91
==========================================
+ Hits 2371 2454 +83
- Misses 384 388 +4
- Partials 88 92 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
synfinatic
force-pushed
the
ssl-support
branch
2 times, most recently
from
5a6f38e to
b196c7c
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
docs/remote-ssh.md
Outdated
| @@ -18,8 +18,7 @@ encrypted over ssh. | |||
|
|
|||
| **Note:** The root user or anyone with [CAP_NET_RAW or CAP_NET_ADMIN](https://man7.org/linux/man-pages/man7/capabilities.7.html) | |||
| will be able to intercept the HTTP traffic on either endpoint and obtain the bearer token | |||
| and/or any IAM Credentials stored in the ECS Server. As of this time, `aws-sso` does | |||
| [not support HTTPS](https://github.com/synfinatic/aws-sso-cli/issues/518) for full end-to-end encryption. | |||
| and/or any IAM Credentials stored in the ECS Server if you have not [enabled SSL](ecs-server.md#enable-ssl). | |||
There was a problem hiding this comment.
🚫 [linkspector] reported by reviewdog 🐶
Cannot reach ecs-server.md#enable-ssl. Status: 404 Cannot find section: #enable-ssl in file: /home/runner/work/aws-sso-cli/aws-sso-cli/docs/ecs-server.md.
synfinatic
force-pushed
the
ssl-support
branch
6 times, most recently
from
ced2158 to
c250e7b
Compare
* add `ecs cert` command to load cert/private key * Stores the cert/private key in the secure store * Re-think how the http auth CLi args work Fixes: #518
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.