Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup docs and remove completions pre-1.9 #1032

Merged
merged 1 commit into from
Aug 20, 2024
Merged

cleanup docs and remove completions pre-1.9 #1032

merged 1 commit into from
Aug 20, 2024

Conversation

synfinatic
Copy link
Owner

  • Update docs that are a bit out of date for 2.0.0
  • Remove completions --uninstall-pre19 flag
  • Cleanup license file to remove lint warnings

Fixes: #1031

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 51.18%. Comparing base (b7757d5) to head (575bd96).
Report is 2 commits behind head on main.

Files Patch % Lines
cmd/aws-sso/completions_cmd.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1032      +/-   ##
==========================================
+ Coverage   51.00%   51.18%   +0.18%     
==========================================
  Files          60       60              
  Lines        5012     4994      -18     
==========================================
  Hits         2556     2556              
+ Misses       2363     2345      -18     
  Partials       93       93              
Flag Coverage Δ
unittests 51.18% <0.00%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cmd/aws-sso/completions_cmd.go 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7757d5...575bd96. Read the comment docs.

 * Update docs that are a bit out of date for 2.0.0
 * Remove completions --uninstall-pre19 flag
 * Cleanup license file to remove lint warnings

Fixes: #1031
@synfinatic synfinatic merged commit cc0f187 into main Aug 20, 2024
6 of 7 checks passed
@synfinatic synfinatic deleted the improve-docs branch August 20, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove completions --uninstall-pre-19
1 participant