Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor the logger to be a singleton and use init() #1005

Merged
merged 1 commit into from
Jul 20, 2024
Merged

Conversation

synfinatic
Copy link
Owner

Cleanup the logger to better follow Go best practices.

Refs: #1001

Copy link

codecov bot commented Jul 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.61%. Comparing base (81e0984) to head (c4f5138).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1005      +/-   ##
==========================================
+ Coverage   84.17%   84.61%   +0.43%     
==========================================
  Files          42       34       -8     
  Lines        3071     3040      -31     
==========================================
- Hits         2585     2572      -13     
+ Misses        393      375      -18     
  Partials       93       93              
Flag Coverage Δ
unittests 84.61% <100.00%> (+0.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
internal/ecs/client/client.go 92.98% <100.00%> (+0.13%) ⬆️
internal/ecs/http.go 100.00% <100.00%> (ø)
internal/ecs/server/server.go 92.94% <100.00%> (+0.17%) ⬆️
internal/helper/helper.go 69.61% <100.00%> (+0.61%) ⬆️
internal/predictor/predictor.go 85.11% <100.00%> (+0.32%) ⬆️
internal/sso/logger.go 100.00% <100.00%> (ø)
internal/storage/storage.go 96.43% <100.00%> (+0.13%) ⬆️
internal/tags/logger.go 100.00% <100.00%> (+66.67%) ⬆️
internal/url/url.go 91.03% <100.00%> (+0.12%) ⬆️
internal/utils/utils.go 96.12% <100.00%> (+0.08%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81e0984...c4f5138. Read the comment docs.

Cleanup the logger to better follow Go best practices.

Refs: #1001
@synfinatic synfinatic merged commit 86be47d into main Jul 20, 2024
7 checks passed
@synfinatic synfinatic deleted the move-logger branch July 20, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant