Skip to content

Commit

Permalink
Merge pull request #1041 from synfinatic/fix-ecs-server
Browse files Browse the repository at this point in the history
ECS Server needs the secure store
  • Loading branch information
synfinatic authored Aug 26, 2024
2 parents 786e202 + ff9edb5 commit 09b3c07
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 1 deletion.
16 changes: 16 additions & 0 deletions .vscode/launch.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
{
// Use IntelliSense to learn about possible attributes.
// Hover to view descriptions of existing attributes.
// For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
"version": "0.2.0",
"configurations": [
{
"name": "Run ECS Server",
"type": "go",
"request": "launch",
"mode": "auto",
"program": "${workspaceFolder}/cmd/aws-sso/",
"args": ["ecs", "server"]
}
]
}
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## [Unreleased]

### Bugs

* Fix running the ECS server outside of docker #104a

## [v2.0.0-beta3] - 2024-08-19

### Bugs
Expand Down
6 changes: 5 additions & 1 deletion cmd/aws-sso/ecs_server_cmd.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,11 @@ type EcsServerCmd struct {

// AfterApply determines if SSO auth token is required
func (e EcsServerCmd) AfterApply(runCtx *RunContext) error {
runCtx.Auth = AUTH_NO_CONFIG
if e.Docker {
runCtx.Auth = AUTH_NO_CONFIG
} else {
runCtx.Auth = AUTH_SKIP
}
return nil
}

Expand Down

0 comments on commit 09b3c07

Please sign in to comment.