Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct the error returning when set ReadOnly #250

Closed
wants to merge 1 commit into from
Closed

Correct the error returning when set ReadOnly #250

wants to merge 1 commit into from

Conversation

Fullstop000
Copy link

No description provided.

@Fullstop000 Fullstop000 mentioned this pull request Dec 8, 2018
Open
@Fullstop000 Fullstop000 changed the title fix: fix https://github.com/syndtr/goleveldb/issues/240 Correct the error returning when set ReadOnly Jan 23, 2019
@syndtr
Copy link
Owner

syndtr commented Aug 15, 2020

if !os.IsNotExist(err) || s.o.GetErrorIfMissing() || s.o.GetReadOnly() { should doing the same thing. If the error caused by db.Open, that is only code path that trigger Storage.SetMeta. I want to fix this in leveldb side not leveldb/storage side.

@syndtr syndtr closed this Aug 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fullstop000 @syndtr