Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Add AMQ connection causes error in UI #4933

Closed
christophd opened this issue Mar 18, 2019 · 7 comments
Closed

Add AMQ connection causes error in UI #4933

christophd opened this issue Mar 18, 2019 · 7 comments
Assignees
@christophd
Labels
cat/bug A bug which needs fixing closed/verified Used by QE to indicate that verified the issue group/ui User interface SPA, talking to the REST backend notif/triage The issue needs triage. Applied automatically to all new issues. prio/p0 The priority of a bug. p0 means blocking

Comments

@christophd
Copy link
Contributor

This is a...


[ ] Feature request
[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Documentation issue or request

Description

Bildschirmfoto 2019-03-18 um 14 31 56

Steps to reproduce: Add AMQ connection as finish connection

Most likely related to #4914 when step action has no tags defined. AMQ connector provides no tags and is just an example.
@christophd christophd added cat/bug A bug which needs fixing group/ui User interface SPA, talking to the REST backend labels Mar 18, 2019
@pure-bot pure-bot bot added the notif/triage The issue needs triage. Applied automatically to all new issues. label Mar 18, 2019
@gashcrumb gashcrumb self-assigned this Mar 18, 2019
christophd added a commit to christophd/syndesis that referenced this issue Mar 18, 2019
@christophd
Fixes syndesisio#4933 Errors in UI when adding connections not provid…
11f2c85 
…ing any tags
@gashcrumb
Copy link
Contributor

Just for the record, these are the kind of inconsistencies that make me go crazy :-)

@zregvart
Copy link
Member

Though ActiveMQ connector does not support dynamic metadata and doesn't advertise its support for it (not tagged with dynamic), as far as I can see.

@gashcrumb
Copy link
Contributor

Yeah, no, it's because the tags property isn't sent then altogether.

@gashcrumb gashcrumb assigned christophd and unassigned gashcrumb Mar 18, 2019
@gashcrumb
Copy link
Contributor

@christophd see you have a commit fixing this, I'll assign it to you, thanks for that!

@zregvart
Copy link
Member

One good thing is that we have connector-schema.json and tooling (thanks to @phantomjinx), and we can refine the schema to be even more exact, and we can develop further tooling to check for discrepancies between connector schema, backend model (= swagger spec) and UI model.

@christophd christophd mentioned this issue Mar 18, 2019
Merged
@christophd christophd added the prio/p0 The priority of a bug. p0 means blocking label Mar 18, 2019
@zregvart
Copy link
Member

Created #4941 so chime in with ideas there...

@gashcrumb gashcrumb mentioned this issue Mar 18, 2019
Closed
gashcrumb added a commit that referenced this issue Mar 18, 2019
@gashcrumb
Merge pull request #4940 from christophd/fix/4933/tagless-connections…
f28ce9d 
…-cause-ui-errors

fix: #4933 Error in UI when adding connections not providing any tags
@pure-bot pure-bot bot locked as resolved and limited conversation to collaborators Mar 18, 2019
@pure-bot pure-bot bot reopened this Mar 18, 2019
@pure-bot pure-bot bot unlocked this conversation Mar 18, 2019
@avano avano added the closed/verified Used by QE to indicate that verified the issue label Mar 19, 2019
@avano
Copy link
Member

avano commented Mar 19, 2019

works ok now

@avano avano closed this as completed Mar 19, 2019
chirino pushed a commit to chirino/syndesis that referenced this issue Mar 31, 2019
@christophd @lburgazzoli
Fixes syndesisio#4933 Errors in UI when adding connections not provid…
6b2cfe0 
…ing any tags
zregvart pushed a commit to zregvart/syndesis that referenced this issue Mar 31, 2019
@christophd @zregvart
Fixes syndesisio#4933 Errors in UI when adding connections not provid…
feecc8a 
…ing any tags
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@christophd christophd

Labels
cat/bug A bug which needs fixing closed/verified Used by QE to indicate that verified the issue group/ui User interface SPA, talking to the REST backend notif/triage The issue needs triage. Applied automatically to all new issues. prio/p0 The priority of a bug. p0 means blocking
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@christophd @gashcrumb @zregvart @avano