Remove feature flag for Links field (twentyhq#5606)

synapsenet-arena · May 27, 2024 · f58c961 · f58c961
1 parent 8579714
commit f58c961
Show file tree

Hide file tree

Showing 6 changed files with 1 addition and 20 deletions.
diff --git a/packages/twenty-front/src/modules/workspace/types/FeatureFlagKey.ts b/packages/twenty-front/src/modules/workspace/types/FeatureFlagKey.ts
@@ -4,5 +4,4 @@ export type FeatureFlagKey =
   | 'IS_EVENT_OBJECT_ENABLED'
   | 'IS_AIRTABLE_INTEGRATION_ENABLED'
   | 'IS_POSTGRESQL_INTEGRATION_ENABLED'
-  | 'IS_STRIPE_INTEGRATION_ENABLED'
-  | 'IS_LINKS_FIELD_ENABLED';
+  | 'IS_STRIPE_INTEGRATION_ENABLED';
diff --git a/...ront/src/pages/settings/data-model/SettingsObjectNewField/SettingsObjectNewFieldStep2.tsx b/...ront/src/pages/settings/data-model/SettingsObjectNewField/SettingsObjectNewFieldStep2.tsx
@@ -32,7 +32,6 @@ import { Section } from '@/ui/layout/section/components/Section';
 import { Breadcrumb } from '@/ui/navigation/bread-crumb/components/Breadcrumb';
 import { View } from '@/views/types/View';
 import { ViewType } from '@/views/types/ViewType';
-import { useIsFeatureEnabled } from '@/workspace/hooks/useIsFeatureEnabled';
 import { FieldMetadataType } from '~/generated-metadata/graphql';
 import { isDefined } from '~/utils/isDefined';
 import { isUndefinedOrNull } from '~/utils/isUndefinedOrNull';
@@ -112,8 +111,6 @@ export const SettingsObjectNewFieldStep2 = () => {
   const { createOneRelationMetadataItem: createOneRelationMetadata } =
     useCreateOneRelationMetadataItem();
 
-  const isLinksFieldEnabled = useIsFeatureEnabled('IS_LINKS_FIELD_ENABLED');
-
   if (!activeObjectMetadataItem) return null;
 
   const canSave =
@@ -263,7 +260,6 @@ export const SettingsObjectNewFieldStep2 = () => {
       FieldMetadataType.Email,
       FieldMetadataType.FullName,
       FieldMetadataType.Link,
-      isLinksFieldEnabled ? undefined : FieldMetadataType.Links,
       FieldMetadataType.Numeric,
       FieldMetadataType.Probability,
       FieldMetadataType.Uuid,

diff --git a/packages/twenty-front/src/testing/mock-data/users.ts b/packages/twenty-front/src/testing/mock-data/users.ts
@@ -50,12 +50,6 @@ export const mockDefaultWorkspace: Workspace = {
       value: true,
       workspaceId: '7dfbc3f7-6e5e-4128-957e-8d86808cdf6w',
     },
-    {
-      id: '1492de61-5018-4368-8923-4f1eeaf988c7',
-      key: 'IS_LINKS_FIELD_ENABLED',
-      value: true,
-      workspaceId: '7dfbc3f7-6e5e-4128-957e-8d86808cdf6w',
-    },
   ],
   createdAt: '2023-04-26T10:23:42.33625+00:00',
   updatedAt: '2023-04-26T10:23:42.33625+00:00',

diff --git a/packages/twenty-server/src/database/typeorm-seeds/core/feature-flags.ts b/packages/twenty-server/src/database/typeorm-seeds/core/feature-flags.ts
@@ -45,11 +45,6 @@ export const seedFeatureFlags = async (
         workspaceId: workspaceId,
         value: true,
       },
-      {
-        key: FeatureFlagKeys.IsLinksFieldEnabled,
-        workspaceId: workspaceId,
-        value: true,
-      },
       {
         key: FeatureFlagKeys.IsContactCreationForSentAndReceivedEmailsEnabled,
         workspaceId: workspaceId,

diff --git a/packages/twenty-server/src/engine/core-modules/feature-flag/feature-flag.entity.ts b/packages/twenty-server/src/engine/core-modules/feature-flag/feature-flag.entity.ts
@@ -22,7 +22,6 @@ export enum FeatureFlagKeys {
   IsPostgreSQLIntegrationEnabled = 'IS_POSTGRESQL_INTEGRATION_ENABLED',
   IsStripeIntegrationEnabled = 'IS_STRIPE_INTEGRATION_ENABLED',
   IsGmailSyncV2Enabled = 'IS_GMAIL_SYNC_V2_ENABLED',
-  IsLinksFieldEnabled = 'IS_LINKS_FIELD_ENABLED',
   IsContactCreationForSentAndReceivedEmailsEnabled = 'IS_CONTACT_CREATION_FOR_SENT_AND_RECEIVED_EMAILS_ENABLED',
 }
 

diff --git a/.../src/engine/workspace-manager/workspace-sync-metadata/commands/add-standard-id.command.ts b/.../src/engine/workspace-manager/workspace-sync-metadata/commands/add-standard-id.command.ts
@@ -59,7 +59,6 @@ export class AddStandardIdCommand extends CommandRunner {
             IS_POSTGRESQL_INTEGRATION_ENABLED: true,
             IS_STRIPE_INTEGRATION_ENABLED: false,
             IS_GMAIL_SYNC_V2_ENABLED: true,
-            IS_LINKS_FIELD_ENABLED: true,
             IS_CONTACT_CREATION_FOR_SENT_AND_RECEIVED_EMAILS_ENABLED: true,
           },
         );
@@ -76,7 +75,6 @@ export class AddStandardIdCommand extends CommandRunner {
           IS_POSTGRESQL_INTEGRATION_ENABLED: true,
           IS_STRIPE_INTEGRATION_ENABLED: false,
           IS_GMAIL_SYNC_V2_ENABLED: true,
-          IS_LINKS_FIELD_ENABLED: true,
           IS_CONTACT_CREATION_FOR_SENT_AND_RECEIVED_EMAILS_ENABLED: true,
         },
       );