Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bonus rewarder #189

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Bonus rewarder #189

wants to merge 19 commits into from

Conversation

ChiTimesChi
Copy link
Collaborator

Description

Adds BonusRewarder, a MinChefV2 extension enabling double rewards for any of the pools present in MiniChefV2.

Every pool in MiniChef can be assigned allocation points for the bonus rewards. In order to opt in for the bonus rewards, user will have to interact with MiniChefV2 after the bonus rewarder was added.

Checklist

  • New Contracts have been tested
  • Lint has been run
  • I have checked my code and corrected any misspellings

@ChiTimesChi
Copy link
Collaborator Author

Things left to do:

  • Make bonus rewards last for a certain amount of time
  • Add tests for bonus rewards targeting more than one pool

@ChiTimesChi
Copy link
Collaborator Author

Main difference between BonusRewarder and MiniChef is that the bonus rewards are paid on every interaction. If contract doesn't have enough tokens to pay, the unpaid rewards are recorded, and paid out on the next user interaction (provided the contract was refilled).

New things:

  • Ability to set a deadline for the bonus rewards (for all pools at once)
  • Ability to claim bonus rewards once BonusRewarder is removed from MiniChef
  • Fixed bug: user who left the pool, but has unpaid rewards, should be able to harvest these rewards without having to deposit again

@ChiTimesChi ChiTimesChi marked this pull request as ready for review December 13, 2022 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant