Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove rookout #3470

Merged
merged 1 commit into from
Dec 19, 2024
Merged

chore: remove rookout #3470

merged 1 commit into from
Dec 19, 2024

Conversation

trajan0x
Copy link
Contributor

@trajan0x trajan0x commented Dec 19, 2024

Description

supersedes ##3469

Summary by CodeRabbit

  • New Features

    • Updated Go version across multiple modules to enhance performance and compatibility.
  • Bug Fixes

    • Removed deprecated and unused dependencies to streamline the codebase and improve stability.
  • Documentation

    • Enhanced clarity in the README.md for metrics configuration, including updates on environment variables and logging transitions.
  • Chores

    • General maintenance updates to dependency management across several modules, ensuring alignment with the latest versions.

Copy link
Contributor

coderabbitai bot commented Dec 19, 2024

Walkthrough

This pull request encompasses a comprehensive update across multiple Go modules in the Sanguine project. The primary focus is on dependency management, with consistent changes observed in go.mod files across various services and components. Key modifications include updating the Go version to 1.22.4, removing specific indirect dependencies like github.com/Rookout/GoSDK and github.com/fallais/logrus-lumberjack-hook, and adjusting replace directives for dependencies such as github.com/gogo/protobuf. The changes also involve cleaning up unused code, such as removing the rookout.go file in the metrics package.

Changes

File/Path Change Summary
agents/go.mod Go version updated, indirect dependencies removed, dependency versions adjusted
contrib/opbot/go.mod Indirect dependencies cleaned up, dependency versions updated
contrib/promexporter/go.mod Go version and toolchain updated, dependencies replaced and removed
contrib/screener-api/go.mod Go version updated, protobuf dependency replaced, indirect dependencies removed
core/go.mod Go version updated, multiple indirect dependencies removed
core/metrics/README.md Documentation updated with environment variable clarifications
core/metrics/base.go Removed startRookout function and related calls
core/metrics/internal/const.go Removed Rookout-related constants
core/metrics/rookout.go Entire file deleted
ethergo/go.mod Go version updated, dependencies replaced and removed
Multiple service go.mod files Consistent updates to Go version, dependency management

Suggested labels

go, size/l, M-deps, M-docs

Suggested reviewers

  • dwasse
  • aureliusbtc
  • ChiTimesChi
  • bigboydiamonds

Poem

🐰 Hop, hop, through the code we go,
Cleaning dependencies, watch them flow!
Rookout's gone, protobuf's anew,
Go version bumped, our modules true!
Dependencies dance, a refactored delight! 🌟


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a89c767 and 6112792.

⛔ Files ignored due to path filters (11)
  • agents/go.sum is excluded by !**/*.sum
  • contrib/opbot/go.sum is excluded by !**/*.sum
  • contrib/promexporter/go.sum is excluded by !**/*.sum
  • contrib/screener-api/go.sum is excluded by !**/*.sum
  • core/go.sum is excluded by !**/*.sum
  • ethergo/go.sum is excluded by !**/*.sum
  • services/cctp-relayer/go.sum is excluded by !**/*.sum
  • services/explorer/go.sum is excluded by !**/*.sum
  • services/omnirpc/go.sum is excluded by !**/*.sum
  • services/rfq/go.sum is excluded by !**/*.sum
  • services/scribe/go.sum is excluded by !**/*.sum
📒 Files selected for processing (15)
  • agents/go.mod (0 hunks)
  • contrib/opbot/go.mod (0 hunks)
  • contrib/promexporter/go.mod (0 hunks)
  • contrib/screener-api/go.mod (0 hunks)
  • core/go.mod (0 hunks)
  • core/metrics/README.md (0 hunks)
  • core/metrics/base.go (0 hunks)
  • core/metrics/internal/const.go (0 hunks)
  • core/metrics/rookout.go (0 hunks)
  • ethergo/go.mod (0 hunks)
  • services/cctp-relayer/go.mod (0 hunks)
  • services/explorer/go.mod (0 hunks)
  • services/omnirpc/go.mod (0 hunks)
  • services/rfq/go.mod (0 hunks)
  • services/scribe/go.mod (0 hunks)
💤 Files with no reviewable changes (15)
  • core/metrics/base.go
  • core/metrics/README.md
  • contrib/opbot/go.mod
  • core/metrics/rookout.go
  • core/metrics/internal/const.go
  • services/cctp-relayer/go.mod
  • ethergo/go.mod
  • core/go.mod
  • contrib/promexporter/go.mod
  • services/scribe/go.mod
  • services/rfq/go.mod
  • services/explorer/go.mod
  • services/omnirpc/go.mod
  • agents/go.mod
  • contrib/screener-api/go.mod

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added go Pull requests that update Go code size/m labels Dec 19, 2024
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@a89c767). Learn more about missing BASE report.
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master       #3470   +/-   ##
============================================
  Coverage          ?   22.49800%           
============================================
  Files             ?         603           
  Lines             ?       51129           
  Branches          ?           0           
============================================
  Hits              ?       11503           
  Misses            ?       38416           
  Partials          ?        1210           
Flag Coverage Δ
cctp-relayer 31.97848% <ø> (?)
core 58.69121% <ø> (?)
ethergo 47.31849% <ø> (?)
explorer 4.93656% <ø> (?)
git-changes-action 23.48315% <ø> (?)
omnirpc 32.65401% <ø> (?)
opbot 0.18282% <ø> (?)
promexporter 6.81642% <ø> (?)
rfq 24.78280% <ø> (?)
screener-api 29.95090% <ø> (?)
scribe 18.18182% <ø> (?)
tools 30.31250% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Deploying sanguine-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6112792
Status: ✅  Deploy successful!
Preview URL: https://f9695b98.sanguine-fe.pages.dev
Branch Preview URL: https://fix-remove-rookout.sanguine-fe.pages.dev

View logs

@trajan0x trajan0x merged commit 40cd70b into master Dec 19, 2024
63 checks passed
@trajan0x trajan0x deleted the fix/remove-rookout branch December 19, 2024 16:47
@coderabbitai coderabbitai bot mentioned this pull request Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code needs-go-generate-services/rfq size/m
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant