api test fixes #3228
api test fixes #3228
Conversation
WalkthroughThe changes in this pull request primarily involve updates to the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
- packages/rest-api/src/constants/bridgeable.ts (2 hunks)
🔇 Additional comments (2)
packages/rest-api/src/constants/bridgeable.ts (2)
997-997: Verify the reclassification of USDC to USDCe on POLYGONThe address previously associated with USDC on the POLYGON chain (0x2791bca1f2de4661ed88a30c99a7a9449aa84174) has now been reclassified as USDCe. This is a significant change in token classification.
+ [CHAINS.POLYGON.id]: '0x2791bca1f2de4661ed88a30c99a7a9449aa84174',Please confirm that this reclassification is intentional and correct. This change could have substantial implications for how these tokens are handled in the system, particularly in terms of bridging operations and user interactions.
To verify this change and its implications, you can run the following script:
#!/bin/bash # Verify the reclassification of USDC to USDCe on Polygon echo "Checking for occurrences of the address in USDC and USDCe definitions" rg --type typescript "0x2791bca1f2de4661ed88a30c99a7a9449aa84174" -C 10 echo "Checking for any references to USDCe on Polygon in other parts of the codebase" rg --type typescript "USDCe.*POLYGON" -C 5This script will help identify any inconsistencies or areas that might need updating due to this reclassification.
Line range hint
1141-1160: Verify the newly added SPECTRAL tokenThe SPECTRAL token has been added with the following properties:
export const SPECTRAL: BridgeableToken = { priorityRank: 600, addresses: { [CHAINS.ETHEREUM.id]: '0xAdF7C35560035944e805D98fF17d58CDe2449389', [CHAINS.BASE.id]: '0x96419929d7949D6A801A6909c145C8EEf6A40431', }, decimals: { [CHAINS.ETHEREUM.id]: 18, [CHAINS.BASE.id]: 18, }, symbol: 'SPEC', name: 'Spectral Token', swapableType: 'SPEC', color: 'blue', routeSymbol: 'SPEC', imgUrl: 'https://105bc697.sanguine-fe.pages.dev/_next/static/media/spectral.6d51750c.svg', }The structure and properties of the SPECTRAL token definition are consistent with other token definitions in the file. However, please verify the following:
- The correctness of the addresses for both ETHEREUM and BASE chains.
- The accuracy of the
decimalsvalues.- The appropriateness of the
priorityRankvalue.- The validity of the
imgUrl.To verify the SPECTRAL token information, you can run the following script:
#!/bin/bash # Verify SPECTRAL token information echo "Checking for other occurrences of SPECTRAL token addresses" rg --type typescript "0xAdF7C35560035944e805D98fF17d58CDe2449389" -C 5 rg --type typescript "0x96419929d7949D6A801A6909c145C8EEf6A40431" -C 5 echo "Checking for any other references to SPECTRAL or SPEC tokens" rg --type typescript "SPECTRAL|SPEC" -C 5This script will help identify any inconsistencies or additional references to the SPECTRAL token that might need attention.
| @@ -434,7 +434,7 @@ export const USDC: BridgeableToken = { | |||
| [CHAINS.AVALANCHE.id]: '0xb97ef9ef8734c71904d8002f8b6bc66dd9c48a6e', | |||
| [CHAINS.DFK.id]: '0x3AD9DFE640E1A9Cc1D9B0948620820D975c3803a', | |||
| [CHAINS.BASE.id]: '0x833589fCD6eDb6E08f4c7C32D4f71b54bdA02913', | |||
| [CHAINS.POLYGON.id]: '0x2791bca1f2de4661ed88a30c99a7a9449aa84174', | |||
| [CHAINS.POLYGON.id]: '0x3c499c542cEF5E3811e1192ce70d8cC03d5c3359', | |||
There was a problem hiding this comment.
💡 Codebase verification
Remove all remaining references to the old USDC address on the POLYGON chain
The old USDC token address '0x2791bca1f2de4661ed88a30c99a7a9449aa84174' is still referenced in multiple parts of the codebase. This could lead to inconsistencies and potential issues with integrations.
- Files containing the old address:
packages/synapse-interface/constants/tokens/bridgeable.tspackages/widget/src/constants/bridgeable.tspackages/rest-api/src/constants/bridgeable.ts
Please update or remove these references to ensure consistency across the codebase.
🔗 Analysis chain
Verify the new USDC address for POLYGON chain
The USDC token address for the POLYGON chain has been updated. This is a significant change that could affect existing integrations and user interactions.
- [CHAINS.POLYGON.id]: '0x2791bca1f2de4661ed88a30c99a7a9449aa84174',
+ [CHAINS.POLYGON.id]: '0x3c499c542cEF5E3811e1192ce70d8cC03d5c3359',Please ensure that this new address is correct and that all necessary updates have been made in other parts of the codebase that might reference this address.
To verify the correctness of this address, you can run the following script:
This script will search for occurrences of both the new and old addresses, helping to ensure consistency across the codebase.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Verify the new USDC address on Polygon
echo "Verifying USDC address on Polygon"
rg --type typescript "0x3c499c542cEF5E3811e1192ce70d8cC03d5c3359" -C 5
echo "Checking for any remaining occurrences of the old address"
rg --type typescript "0x2791bca1f2de4661ed88a30c99a7a9449aa84174" -C 5
Length of output: 548
Script:
#!/bin/bash
# Verify the new USDC address on Polygon with corrected file type
echo "Verifying USDC address on Polygon"
rg --type ts "0x3c499c542cEF5E3811e1192ce70d8cC03d5c3359" -C 5
echo "Checking for any remaining occurrences of the old address"
rg --type ts "0x2791bca1f2de4661ed88a30c99a7a9449aa84174" -C 5
Length of output: 29272
Deploying sanguine-fe with
|
| Latest commit: |
e50fb81
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f78fd58a.sanguine-fe.pages.dev |
| Branch Preview URL: | https://fix-api-tests.sanguine-fe.pages.dev |
Bundle ReportBundle size has no change ✅ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3228 +/- ##
============================================
Coverage ? 90.43902%
============================================
Files ? 54
Lines ? 1025
Branches ? 82
============================================
Hits ? 927
Misses ? 95
Partials ? 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
For some reason USDCe was missing and thus tests were failing
Summary by CodeRabbit
New Features
USDCandUSDCetokens on the POLYGON chain.SPECTRAL, with complete properties including address, symbol, and image URL.Bug Fixes