Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update foundry tag #1265

Merged
merged 3 commits into from
Aug 18, 2023
Merged

update foundry tag #1265

merged 3 commits into from
Aug 18, 2023

Conversation

trajan0x
Copy link
Contributor

@trajan0x trajan0x commented Aug 18, 2023

Description

Fixes foundry tag, if this works thanks to foundry-rs/foundry#5414 should pave the path for a built in explorer for foundry backends

I managed to fix this before opening up an issue on foundry, but here's my draft below if useful:

Since 6e041f9751efa6b75420689b862df05b0934022b I've noticed what I think is a regression (and is definitely a behavior change in anvil) with regards to handling of account impersonation and unsigned transaction handling. At commit 7398b65e831f2339d1d0a0bb05ade799e4f9d01e (the previous commit, the following sequence was possible:

image

You can test this yourself by running the account impersonation test here. This will run against nightly-7398b65e831f2339d1d0a0bb05ade799e4f9d01e and work fine.

At the very next commit (up to latest/nightly tags) this same sequence will not work. You can try this out here: #1265 or by adjusting the tag yourself. The following error is returned:

image

What I'm not sure about is if this is a regression is implicit or if the previous behavior was incorrect and my code just worked with it. I can see foundry-rs/foundry/pull/4663 does enforce the checking of type.

Is the intended behavior that both maxFeePerGas and maxPriorityFeePerGas must be set if type 2 is used?

The answer was yes.

@github-actions github-actions bot added go Pull requests that update Go code size/xs labels Aug 18, 2023
@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Patch coverage: 55.55556% and project coverage change: -0.08891% ⚠️

Comparison is base (2a5a67b) 60.29455% compared to head (bec60e8) 60.20564%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@                 Coverage Diff                 @@
##              master       #1265         +/-   ##
===================================================
- Coverage   60.29455%   60.20564%   -0.08891%     
===================================================
  Files            564         566          +2     
  Lines          34086       34138         +52     
  Branches         276         276                 
===================================================
+ Hits           20552       20553          +1     
- Misses         11673       11726         +53     
+ Partials        1861        1859          -2     
Flag Coverage Δ
cctp-relayer 65.31303% <ø> (ø)
ethergo 63.42155% <55.55556%> (-0.22486%) ⬇️
explorer 53.40488% <ø> (ø)
omnirpc 70.12480% <ø> (ø)
promexporter 41.02564% <ø> (?)
scribe 57.03490% <ø> (-0.46677%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
ethergo/backends/anvil/client.go 74.31193% <50.00000%> (-8.84596%) ⬇️
ethergo/backends/anvil/anvil.go 84.58333% <100.00000%> (-0.06397%) ⬇️

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trajan0x trajan0x changed the title fix foundry tag update foundry tag Aug 18, 2023
@trajan0x trajan0x changed the title update foundry tag update foundry tag for otterscan Aug 18, 2023
@trajan0x trajan0x changed the title update foundry tag for otterscan update foundry tag Aug 18, 2023
@github-actions github-actions bot added size/s and removed size/xs labels Aug 18, 2023
@trajan0x trajan0x marked this pull request as ready for review August 18, 2023 20:08
@trajan0x trajan0x merged commit e7b05a1 into master Aug 18, 2023
@trajan0x trajan0x deleted the feat/foundry-latest branch August 18, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code size/s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant