Add benchmarks for pseudo quotient method #93
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
71
to
73
| return f, g, d, syms | ||
|
|
||
|
|
||
| class _QuadraticNonMonicGCD(_GCDExample): |
There was a problem hiding this comment.
Why are these lines deleted? Usually there should be two lines between top level statements like def and class.
There was a problem hiding this comment.
I thought there should be one line between subclasses, I will correct myself.
|
Closing! |
I meant that we don't need to time all 4 methods. I think that we should have benchmarks for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the benchmarks for the pseudo-remainder method.
Related Issue:
#88
See sympy/sympy#25278