-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add linters #85
base: master
Are you sure you want to change the base?
Add linters #85
Conversation
LukasMoll
commented
Mar 26, 2023
•
edited
Loading
edited
- Added linter configs (copied from sympy, removed exclude and per-ignore-files)
- Applied linter code conventions
This is good. Thanks. You'll need to also enable a flake8 check in the CI. |
Thanks for the feedback. I copied and modified the runtests.yml file from the sympy project. I modified this file to only contain the instructions for flake8 for this project. I can add the others (ruff, mypy) in the future. |
What is the purpose of having mypy? I don't quite see how that is relevant for a set of benchmarks. |
I think it's nice to have to catch type related bugs and to enforce some code conventions. Example error it's showing now: I understand that it can be more annoying then useful, I'll remove mypy. |
My preference is to remove mypy. |
_ = self.Case3**4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_ = self.Case3**4 | |
_ = self.Case3**4 | |
@@ -239,6 +242,9 @@ def time_combined_cse(self): | |||
cse([self.y, self.G]) | |||
|
|||
|
|||
S = SingletonRegistry() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this can be imported from sympy
I think that |
Thanks. |