Skip to content

Commit

Permalink
Fix offline test execution problem regarding maven not finding `org.a…
Browse files Browse the repository at this point in the history
…pache.maven.surefire:surefire-junit4:jar:2.20.1` and `dummy:dummy:jar:1.0` dependencies while offline

Apparently the `surefire-junit4` dependency needs to be listed explicitly as the plugin's dependency, so that `mvn dependency:go-offline` could see it needs to be downloaded too.

There was a nice discussion over here:
  googleapis/google-cloud-java#3819
  googleapis/google-cloud-java#3820
  • Loading branch information
indrek-priks-sympower committed Mar 19, 2019
1 parent a891d0a commit 32539d9
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,13 @@
<exclude>**/PackageTest.java</exclude>
</excludes>
</configuration>
<dependencies>
<dependency>
<groupId>org.apache.maven.surefire</groupId>
<artifactId>surefire-junit4</artifactId>
<version>2.20.1</version>
</dependency>
</dependencies>
</plugin>

<plugin>
Expand Down

0 comments on commit 32539d9

Please sign in to comment.