Change NoReturnArrayVariableListRule to ignore array spreads #139
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many times we return an array which contains a number of array spreads in order to merge all these arrays and return a single one:
The
NoReturnArrayVariableListRule
sees that we are returning an array composed of two expressions and will return an error asking us to use a value object instead. This is clearly not appropriate for this caseThis PR fixes this problem by ignoring array spreads when counting the number of expressions in the returned array