Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove NoEmptyClassRule, as rarely true and already coverd by class-leak #124

Merged
merged 2 commits into from
May 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion config/static-rules.neon
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ rules:

- Symplify\PHPStanRules\Rules\Complexity\ForbiddenArrayMethodCallRule
- Symplify\PHPStanRules\Rules\CheckRequiredInterfaceInContractNamespaceRule
- Symplify\PHPStanRules\Rules\NoEmptyClassRule

# naming
- Symplify\PHPStanRules\Rules\RequireAttributeNameRule
29 changes: 0 additions & 29 deletions docs/rules_overview.md
Original file line number Diff line number Diff line change
Expand Up @@ -645,35 +645,6 @@ class SomeClass

<br>

## NoEmptyClassRule

There should be no empty class

- class: [`Symplify\PHPStanRules\Rules\NoEmptyClassRule`](../src/Rules/NoEmptyClassRule.php)

```php
class SomeClass
{
}
```

:x:

<br>

```php
class SomeClass
{
public function getSome()
{
}
}
```

:+1:

<br>

## NoInlineStringRegexRule

Use local named constant instead of inline string for regex to explain meaning by constant name
Expand Down
136 changes: 0 additions & 136 deletions src/Rules/NoEmptyClassRule.php

This file was deleted.

10 changes: 0 additions & 10 deletions tests/Rules/NoEmptyClassRule/Fixture/SkipAttribute.php

This file was deleted.

This file was deleted.

11 changes: 0 additions & 11 deletions tests/Rules/NoEmptyClassRule/Fixture/SkipException.php

This file was deleted.

11 changes: 0 additions & 11 deletions tests/Rules/NoEmptyClassRule/Fixture/SkipFinalChildOfAbstract.php

This file was deleted.

9 changes: 0 additions & 9 deletions tests/Rules/NoEmptyClassRule/Fixture/SkipMarkerInterface.php

This file was deleted.

12 changes: 0 additions & 12 deletions tests/Rules/NoEmptyClassRule/Fixture/SkipWithCommentAbove.php

This file was deleted.

10 changes: 0 additions & 10 deletions tests/Rules/NoEmptyClassRule/Fixture/SkipWithCommentInterface.php

This file was deleted.

10 changes: 0 additions & 10 deletions tests/Rules/NoEmptyClassRule/Fixture/SkipWithContent.php

This file was deleted.

10 changes: 0 additions & 10 deletions tests/Rules/NoEmptyClassRule/Fixture/SomeEmptyClass.php

This file was deleted.

50 changes: 0 additions & 50 deletions tests/Rules/NoEmptyClassRule/NoEmptyClassRuleTest.php

This file was deleted.

10 changes: 0 additions & 10 deletions tests/Rules/NoEmptyClassRule/Source/AbstractAnother.php

This file was deleted.

10 changes: 0 additions & 10 deletions tests/Rules/NoEmptyClassRule/Source/AnInterface.php

This file was deleted.

5 changes: 0 additions & 5 deletions tests/Rules/NoEmptyClassRule/config/configured_rule.neon

This file was deleted.

Loading