Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove NoRelativeFilePathRule as more exceptoins #118

Merged
merged 2 commits into from
May 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion config/code-complexity-rules.neon
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,4 @@ rules:
- Symplify\PHPStanRules\Rules\Explicit\NoMixedMethodCallerRule
- Symplify\PHPStanRules\Rules\Enum\RequireEnumDocBlockOnConstantListPassRule
- Symplify\PHPStanRules\Rules\NoDynamicNameRule
- Symplify\PHPStanRules\Rules\Explicit\NoRelativeFilePathRule
- Symplify\PHPStanRules\Rules\NoReturnArrayVariableListRule
24 changes: 1 addition & 23 deletions docs/rules_overview.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# 45 Rules Overview
# 44 Rules Overview

## AnnotateRegexClassConstWithRegexLinkRule

Expand Down Expand Up @@ -959,28 +959,6 @@ class SomeClass

<br>

## NoRelativeFilePathRule

Relative file path "%s" is not allowed, use absolute one with __DIR__

- class: [`Symplify\PHPStanRules\Rules\Explicit\NoRelativeFilePathRule`](../src/Rules/Explicit/NoRelativeFilePathRule.php)

```php
$filePath = 'some_file.txt';
```

:x:

<br>

```php
$filePath = __DIR__ . '/some_file.txt';
```

:+1:

<br>

## NoReturnArrayVariableListRule

Use value object over return of values
Expand Down
89 changes: 0 additions & 89 deletions src/NodeVisitor/StringOutsideConcatFindingNodeVisitor.php

This file was deleted.

155 changes: 0 additions & 155 deletions src/Rules/Explicit/NoRelativeFilePathRule.php

This file was deleted.

This file was deleted.

This file was deleted.

13 changes: 0 additions & 13 deletions tests/Rules/Explicit/NoRelativeFilePathRule/Fixture/SkipEmails.php

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Loading
Loading