Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BoolishClassMethodPrefixRule as very limited and often ignored #114

Merged
merged 4 commits into from
May 19, 2024

Conversation

TomasVotruba
Copy link
Member

@TomasVotruba TomasVotruba commented May 18, 2024

The prefix for bool methods can be more than is/has/was, like should, could, must etc. The range is so wide it would take a full dictionary analysis to ensure we're covering all the cases.

Instead of ignoring the rule by message, better remove the rule

@TomasVotruba TomasVotruba changed the title tv is has Remove BoolishClassMethodPrefixRule as very limited and often ignored May 18, 2024
@TomasVotruba TomasVotruba merged commit 7b9c561 into main May 19, 2024
6 checks passed
@TomasVotruba TomasVotruba deleted the tv-is-has branch May 19, 2024 01:52
@TomasVotruba TomasVotruba restored the tv-is-has branch May 19, 2024 01:54
@TomasVotruba TomasVotruba deleted the tv-is-has branch June 2, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant