fix(yml): fix comment in milti line value

symfony · Jul 30, 2019 · 1a0bae0 · 1a0bae0
1 parent 051d045
commit 1a0bae0
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/Parser.php b/Parser.php
@@ -436,6 +436,9 @@ private function doParse($value, $flags)
                     $value = '';
 
                     foreach ($this->lines as $line) {
+                        if ('' !== ltrim($line) && '#' === ltrim($line)[0]) {
+                            continue;
+                        }
                         // If the indentation is not consistent at offset 0, it is to be considered as a ParseError
                         if (0 === $this->offset && !$deprecatedUsage && isset($line[0]) && ' ' === $line[0]) {
                             throw new ParseException('Unable to parse.', $this->getRealCurrentLineNb() + 1, $this->currentLine, $this->filename);

diff --git a/Tests/ParserTest.php b/Tests/ParserTest.php
@@ -2292,6 +2292,18 @@ public function indentedMappingData()
 
         return $tests;
     }
+
+    public function testMultiLineComment()
+    {
+        $yaml = <<<YAML
+parameters:
+    abc
+
+# Comment 
+YAML;
+
+        $this->assertSame(['parameters' => 'abc'], $this->parser->parse($yaml));
+    }
 }
 
 class B