feat: add Encore.when() #963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
requested changes
Apr 15, 2021
weaverryan
approved these changes
Apr 22, 2021
| @@ -1596,6 +1596,29 @@ class Encore { | |||
| return webpackConfig.isDevServer(); | |||
| } | |||
|
|
|||
| /** | |||
| * Use to conditionally configure or enable features only in when the first parameter results to "true". | |||
There was a problem hiding this comment.
Suggested change
| * Use to conditionally configure or enable features only in when the first parameter results to "true". | |
| * Use to conditionally configure or enable features only when the first parameter results to "true". |
| * // passing a callback | ||
| * .when((Encore) => Encore.isProduction(), (Encore) => Encore.enableVersioning()) | ||
| * // passing a boolean | ||
| * .when(process.argv.includes('--analyze'), (Encore) => Encore.addPlugin(new BundleAnalyzerPlugin())) |
|
This is very cool - thank you @Kocal! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace #900 by adding a more generic and flexible API than
Encore.isDev()/Encore.isProd(), see #900 (comment).Encore.when()takes two parameters:condition: can be a callback (where the current instance of Encore is passed as first parameter) or a boolean. If this results totrue, the parametercallbackis calledcallback: executed when parameterconditionresults totrue, it takes the current instance of Encore as first parameterWDYT? Thanks!