Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow sass-loader:^13.0.0, require node >= 14 #1122

Merged
merged 1 commit into from
May 31, 2022
Merged

Allow sass-loader:^13.0.0, require node >= 14 #1122

merged 1 commit into from
May 31, 2022

Conversation

jmsche
Copy link
Contributor

@jmsche jmsche commented May 23, 2022

Closes #1121

@jmsche
Copy link
Contributor Author

jmsche commented May 23, 2022

Hi @weaverryan, I know why the builds fail; however what am I supposed to do? Revert the change in yarn.lock?

@weaverryan
Copy link
Member

Lol, yup, I expected this. Node packages drop support for old Node versions quite aggressively.

Bump our (Encore's) minimum Node version to 14. And then we'll do a 3.0 release. Ref: #1079 (comment)

@jmsche jmsche changed the title Allow sass-loader:^13.0.0 Allow sass-loader:^13.0.0, require node >= 14 May 25, 2022
@jmsche
Copy link
Contributor Author

jmsche commented May 25, 2022

Done :)

By the way do you want me to add node 18 to the workflows?

@weaverryan
Copy link
Member

Hmm, yes! That would be great - good catch!

@weaverryan
Copy link
Member

Hmm. Node 18 tests fail... even using the "locked" dependencies. And the failure is weird... I'm not sure what's going on...

@jmsche
Copy link
Contributor Author

jmsche commented May 31, 2022

Just ran tests for node 18 locally (thank you nvm), aaaaand... they all pass.

@weaverryan
Copy link
Member

Grrrr. Those are the worst! I'm going to merge... and hope that the issue just solves itself.

@weaverryan
Copy link
Member

Thank you @jmsche!

@weaverryan weaverryan merged commit 5322a03 into symfony:main May 31, 2022
@weaverryan weaverryan added the Feature New Feature label Jul 8, 2022
@jmsche jmsche deleted the sass-loader-13 branch March 22, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Feature New Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warning on sass-loader 13
2 participants
@jmsche @weaverryan