-
-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Vue] Introduce Vue UX component #426
Conversation
CI fail is unrelated, I fixed it in #427 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is wonderful work! Very minor comments
src/Vue/README.md
Outdated
# Symfony UX Vue.js | ||
|
||
Symfony UX Vue integrates [Vue.js](https://vuejs.org/) into Symfony applications. | ||
It provides tools to render Vue.js components from Twig. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't do it until after the PR is merged (and the subtree split is setup), but we will also need to add a demo to ux.symfony.com and linking to it from here would be greta.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passing by and reminded me one of my PR symfony/symfony-docs#16403
Could it be great to show case example of vuejs mounting with object serialized given to?
More a real ex as just passing a « name »
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm already planning to add a ux.symfony.com example (maybe in a following PR ?).
I'll link it here when ready 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great 👍🏻
"keywords": [ | ||
"symfony-ux" | ||
], | ||
"homepage": "https://symfony.com", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can it be the ux.symfony.com ?
(I do not know the standards)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the same for all UX components at the moment. Changing this would require to update all components and not sure it's wanted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a great PR, thanks so much!
I've added docs and fixed the review comments. I'll do the ux.symfony.com page in a separate PR. CI is still failing due to the Chart.js error but built files are up to date for the Vue component. |
Thanks @t-richard for working on this feature, this is much appreciated. |
This PR introduces a UX Vue component which allows to render Vue.js components inside Twig templates, with the ability to pass down props to Vue components from Twig. It is implemented in the same way as the UX React component for coherence.
registerVueControllerComponents
inapp.js
to register Vue componentsHello.vue
) inside the folder specified above (hereassets/vue/controllers
)The implementation was heavily inspired by the work from @tgalopin in #329 (that's why I left him as author everywhere).
I'll gladly write docs and ux.symfony.com samples if accepted and once we agree on the API.
NB: Only Vue.js v3 is supported