-
-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Icons][Twig-Component] Update documentation for installation ux icons #1993
Comments
There is a note in the doc: https://symfony.com/bundles/ux-icons/current/index.html#html-syntax-1. We agree to say that the HTML syntax is not working for you, but if you use the twig function, does it work? |
I did it with the html syntax and it didn't work. But I haven't tried the twig function |
The component does not require TwigComponent, as it works with the Twig function The two times we show HTML syntax, there is a note explaining
And we don't want to force / push anyone to install Twig component if they don't need it. So i'm not sure how we could do it better there: do you maybe have a suggestion @Erwanou77 ? |
Ah yes indeed, I had not seen the ux twig component. |
Maybe putting it in red could be a good idea, because in fact I haven't seen this note |
Yes it's already a little better, but maybe put it at the beginning of the documentation. |
…dre) This PR was merged into the 2.x branch. Discussion ---------- [Icon] Emphasis HTML syntax requires TwigComponent First time HTML syntax is shown, use "tip" (green borders) instead of "note" Fix: #1993 | Before | After | | - | - | | ![Capture d’écran 2024-07-17 à 21 17 54 - Grande](https://github.com/user-attachments/assets/e344aa2c-d0d7-4dfb-bf09-bc4a2efcae14) | <img width="969" alt="Capture d’écran 2024-07-17 à 21 29 14" src="https://github.com/user-attachments/assets/bc5cfa67-801c-4018-8173-8ee9f647e8eb"> | Commits ------- f7838b7 [Icon] Emphasis HTML syntax requires TwigComponent
Hi everyone,
I just initialized a new symfony project, and I wanted to first install the ux icons library but it doesn't work until twig components is installed.
You should add at the beginning of the ux icons documentation that you must first install ux twig component then ux icons
The text was updated successfully, but these errors were encountered: