[Translation] fix multi-byte code area to convert #53588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The right source in CssToInlineStyles is rather tijsverkoyen/CssToInlineStyles#237, which discusses the issue you fix here. |
|
I mentioned the other issue as it claimed that the initially broken fix was taken from the Symfony source code which led me to search for it. |
|
But that does not explain why you do this change here as the issue you link does mention any issue with the code taken from Symfony... |
|
fair enough, I have updated the PR description |
stof
approved these changes
Jan 22, 2024
|
Thank you @xabbuh. |
This was referenced Jan 30, 2024
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging #47783 I stumbled upon tijsverkoyen/CssToInlineStyles#237 which made me realise that we suffer from the same issue in
PseudoLocalizationTranslator. So I decided to apply the patch from tijsverkoyen/CssToInlineStyles#238 here.