feature #10570 [PropertyAccess] Added isReadable() and isWritable() (…

…webmozart)

This PR was merged into the 2.5-dev branch.

Discussion
----------

[PropertyAccess] Added isReadable() and isWritable()

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #8659
| License       | MIT
| Doc PR        | symfony/symfony-docs#3729

This PR introduces BC breaks that are described in detail in the UPGRADE file. The BC breaks conform to our policy. They shouldn't affect many people, so I think we can safely do them.

Commits
-------

f7fb855 [PropertyAccess] Added missing exceptions to phpdoc
9aee2ad [PropertyAccess] Removed the argument $value from isWritable()
4262707 [PropertyAccess] Fixed CS and added missing documentation
6d2af21 [PropertyAccess] Added isReadable() and isWritable()
20e6bf8 [PropertyAccess] Refactored PropertyAccessorCollectionTest
0488389 [PropertyAccess] Refactored PropertyAccessorTest

UPGRADE-2.5.md

@@ -45,6 +45,47 @@ Form
    {
    ```
 
+PropertyAccess
+--------------
+
+ * The methods `isReadable()` and `isWritable()` were added to
+   `PropertyAccessorInterface`. If you implemented this interface in your own
+   code, you should add these two methods.
+
+ * The methods `getValue()` and `setValue()` now throw an
+   `NoSuchIndexException` instead of a `NoSuchPropertyException` when an index
+   is accessed on an object that does not implement `ArrayAccess`. If you catch
+   this exception in your code, you should adapt the catch statement:
+
+   Before:
+
+   ```php
+   $object = new \stdClass();
+
+   try {
+       $propertyAccessor->getValue($object, '[index]');
+       $propertyAccessor->setValue($object, '[index]', 'New value');
+   } catch (NoSuchPropertyException $e) {
+       // ...
+   }
+   ```
+
+   After:
+
+   ```php
+   $object = new \stdClass();
+
+   try {
+       $propertyAccessor->getValue($object, '[index]');
+       $propertyAccessor->setValue($object, '[index]', 'New value');
+   } catch (NoSuchIndexException $e) {
+       // ...
+   }
+   ```
+
+   A `NoSuchPropertyException` is still thrown when a non-existing property is
+   accessed on an object or an array.
+
 Validator
 ---------
 
@@ -56,7 +97,7 @@ Validator
 
    After:
 
-   Default email validation is now done via a simple regex which may cause invalid emails (not RFC compilant) to be 
+   Default email validation is now done via a simple regex which may cause invalid emails (not RFC compilant) to be
    valid. This is the default behaviour.
 
    Strict email validation has to be explicitly activated in the configuration file by adding

src/Symfony/Component/PropertyAccess/CHANGELOG.md

@@ -5,6 +5,10 @@ CHANGELOG
 ------
 
  * allowed non alpha numeric characters in second level and deeper object properties names
+ * [BC BREAK] when accessing an index on an object that does not implement
+   ArrayAccess, a NoSuchIndexException is now thrown instead of the
+   semantically wrong NoSuchPropertyException
+ * [BC BREAK] added isReadable() and isWritable() to PropertyAccessorInterface
 
 2.3.0
 ------

src/Symfony/Component/PropertyAccess/Exception/InvalidArgumentException.php

@@ -0,0 +1,21 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\Component\PropertyAccess\Exception;
+
+/**
+ * Base InvalidArgumentException for the PropertyAccess component.
+ *
+ * @author Bernhard Schussek <[email protected]>
+ */
+class InvalidArgumentException extends \InvalidArgumentException implements ExceptionInterface
+{
+}