Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tip for headers already send error. #8994

Closed
wants to merge 1 commit into from
Closed

Add tip for headers already send error. #8994

wants to merge 1 commit into from

Conversation

rehoehle
Copy link

@rehoehle rehoehle commented Jan 6, 2018

Change for the problem PHPUnit headers already send.

symfony/symfony#25615

Change for the problem PHPUnit headers already send. 

symfony/symfony#25615
@javiereguiluz
Copy link
Member

@rehoehle it's true that you need this to avoid the problem you mentioned ... but this is exactly the default value provided by Symfony:

So, should we still add this to the docs? What do you think @xabbuh? Thanks!

@rehoehle
Copy link
Author

@javiereguiluz i had an error regards this:

symfony/symfony#25615

this is why @sroze mentioned to add that to the documentation. In my configuration that was created after upgrading to Symfony 3.4 the line was commented.

@xabbuh
Copy link
Member

xabbuh commented Jan 22, 2018

@rehoehle Could it be that you started your project at a time where this option was not set in the test environment?

@xabbuh
Copy link
Member

xabbuh commented Jan 22, 2018

for the record: symfony/recipes#333 is not so old

@javiereguiluz
Copy link
Member

@rehoehle as you said in the original issue (symfony/symfony#25615) this has been worked like a charm for years ... and it will keep working. The problem was temporary and because of a bug in the recipe used by Symfony Flex when installing the FrameworkBundle. But this has been fixed so everything should be working again and users shouldn't need to make any change.

That's why I'm closing ... but we'll reopen if the problem wasn't really fixed. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants