Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Contributing][Code] remove PHPUnit requirement #6668

Merged
merged 1 commit into from
Jun 21, 2016
Merged

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jun 21, 2016

PHPUnit is no longer a requirement to test patches for the Symfony core
as we ship a wrapper script that will take care to install the required
PHPUnit version matching the user's environment and must be used to run
Symfony's test suite.

PHPUnit is no longer a requirement to test patches for the Symfony core
as we ship a wrapper script that will take care to install the required
PHPUnit version matching the user's environment and must be used to run
Symfony's test suite.
@javiereguiluz
Copy link
Member

javiereguiluz commented Jun 21, 2016

👍

Status: reviewed

Moreover, the Tests section of the contribution guide already uses the PHPUnit wrapper instead of the real PHPUnit binary.

@wouterj
Copy link
Member

wouterj commented Jun 21, 2016

Thanks Christian.

@wouterj wouterj merged commit b6821de into symfony:2.7 Jun 21, 2016
wouterj added a commit that referenced this pull request Jun 21, 2016
This PR was merged into the 2.7 branch.

Discussion
----------

[Contributing][Code] remove PHPUnit requirement

PHPUnit is no longer a requirement to test patches for the Symfony core
as we ship a wrapper script that will take care to install the required
PHPUnit version matching the user's environment and must be used to run
Symfony's test suite.

Commits
-------

b6821de [Contributing][Code] remove PHPUnit requirement
@xabbuh xabbuh deleted the phpunit branch June 22, 2016 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants