Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5953 use kernel events constants #6591

Closed
wants to merge 2 commits into from
Closed

5953 use kernel events constants #6591

wants to merge 2 commits into from

Conversation

snoek09
Copy link

@snoek09 snoek09 commented May 21, 2016

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets #5953

wouterj
wouterj reviewed May 21, 2016
View reviewed changes
components/event_dispatcher/container_aware_dispatcher.rst
@@ -98,3 +98,4 @@ The ``EventSubscriberInterface`` is exactly as you would expect::
// ...
}
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line should be removed

Copy link
Author

@snoek09 snoek09 May 21, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my editor complained that it was needed; blank line is required after literal block

@xabbuh
Copy link
Member

xabbuh commented May 21, 2016

👍

wouterj added a commit that referenced this pull request May 21, 2016
@wouterj
minor #6591 5953 use kernel events constants (snoek09)
c27eda9 
This PR was squashed before being merged into the 2.3 branch (closes #6591).

Discussion
----------

5953 use kernel events constants

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets | #5953

Commits
-------

ad0e377 5953 use kernel events constants
wouterj added a commit that referenced this pull request May 21, 2016
@wouterj
[#6591] Remove redundant empty line
63ef881
@wouterj
Copy link
Member

wouterj commented May 21, 2016

Thanks @snoek09! This is now included in the docs

@wouterj wouterj closed this May 21, 2016
@snoek09 snoek09 deleted the 5953-use-kernel-events-constants branch May 21, 2016 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@snoek09 @xabbuh @wouterj