Clarify signed requests in the ESI renderer #6589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .. caution:: | ||
|
|
||
| The fragment listener only responds to signed requests. Requests are only | ||
| signed when using fragment renderer and the ``render_esi`` Twig function. |
There was a problem hiding this comment.
By the way, this applies to all renderers extending the AbstractSurrogateFragmentRenderer.
There was a problem hiding this comment.
Yeah, but as this section is about ESI specifically, I only mentioned render_esi to not make things more complex.
Btw, fixed your other comment.
|
👍 |
1 similar comment
|
👍 |
wouterj
added a commit
that referenced
this pull request
May 21, 2016
This PR was merged into the 2.3 branch. Discussion ---------- Clarify signed requests in the ESI renderer I think this clarification makes things more clear to readers. It also explains why something might not work when people don't use the `render_esi` helper function. Commits ------- 7bad395 Clarify signed requests in the ESI renderer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this clarification makes things more clear to readers. It also explains why something might not work when people don't use the
render_esihelper function.