Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a description for the use_microseconds parameter introduced in MonologBundle v2.11 #6583

Closed
wants to merge 2 commits into from

Conversation

jorgelbg
Copy link
Contributor

This adds a small paragraph bellow the usage section with an explanation and an example block.

Q A
Doc fix? yes
New docs? no
Applies to >= 2.3
Fixed tickets #6466

@jorgelbg jorgelbg changed the title Adding a description for the use_microseconds parameter introduced in MonologBundle v2.11 Adding a description for the use_microseconds parameter May 21, 2016
@jorgelbg jorgelbg changed the title Adding a description for the use_microseconds parameter Adding a description for the use_microseconds parameter in monolog May 21, 2016
@jorgelbg jorgelbg changed the title Adding a description for the use_microseconds parameter in monolog Adding a description for the use_microseconds parameter introduced in MonologBundle v2.11 May 21, 2016

// app/config/config.php
$container->loadFromExtension('monolog', array(
'use_microseconds' => false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing comma after false

@wouterj
Copy link
Member

wouterj commented May 21, 2016

I would add this in a new section just after "How to Rotate your Log Files" (e.g. "How to Disable Microseconds Precision").

@jorgelbg
Copy link
Contributor Author

I've added a new section with the suggested title

@wouterj
Copy link
Member

wouterj commented May 21, 2016

I like it, good work! 👍

@jorgelbg
Copy link
Contributor Author

Thanks!!

@xabbuh
Copy link
Member

xabbuh commented May 21, 2016

👍

@xabbuh
Copy link
Member

xabbuh commented May 21, 2016

Thank you @jorgelbg.

xabbuh added a commit that referenced this pull request May 21, 2016
… introduced in MonologBundle v2.11 (jorgelbg)

This PR was squashed before being merged into the 2.3 branch (closes #6583).

Discussion
----------

Adding a description for the use_microseconds parameter introduced in MonologBundle v2.11

This adds a small paragraph bellow the usage section with an explanation and an example block.

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | >= 2.3
| Fixed tickets | #6466

Commits
-------

4c5d42f Adding a description for the use_microseconds parameter introduced in MonologBundle v2.11
@xabbuh xabbuh closed this May 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants